Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ask push notification runtime permission on Android #2213

Merged
merged 7 commits into from
Jan 12, 2024
Merged

Conversation

siepra
Copy link
Contributor

@siepra siepra commented Jan 12, 2024

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

Description

Solves #2205

@siepra
Copy link
Contributor Author

siepra commented Jan 12, 2024

Android Detox tests passed once on my local instance, although there's a problem which doesn't seem to be related to the changes made in this PR, which breaks Detox runs #2214

@siepra siepra requested a review from kowalski January 12, 2024 13:31
@siepra siepra merged commit 2f92e88 into develop Jan 12, 2024
9 of 10 checks passed
siepra added a commit that referenced this pull request Jan 17, 2024
* fix: ask push notification runtime permission on Android

* chore: update CHANGELOG.md

* fix: mobile e2e yaml syntax

* chore: trigger mobile workflows

* Revert "chore: trigger mobile workflows"

This reverts commit 0b15028.

* fix: cleanup username creation component

* Revert "fix: cleanup username creation component"

This reverts commit ced43dd.
@siepra siepra deleted the fix/2205 branch January 17, 2024 12:51
leblowl pushed a commit that referenced this pull request Jan 18, 2024
* fix: ask push notification runtime permission on Android

* chore: update CHANGELOG.md

* fix: mobile e2e yaml syntax

* chore: trigger mobile workflows

* Revert "chore: trigger mobile workflows"

This reverts commit 0b15028.

* fix: cleanup username creation component

* Revert "fix: cleanup username creation component"

This reverts commit ced43dd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants